[ 
https://issues.apache.org/jira/browse/HBASE-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526167#comment-15526167
 ] 

Phil Yang commented on HBASE-16664:
-----------------------------------

{quote}
NO, callable is created outside of AP
{quote}
Sorry, it was my fault. But we still need the changing in the patch. Because in 
RetryingTimeTracker we will never return a non-positive value unless we pass a 
zero in callTimeout. Unfortunately, we can not change this logic because it 
will break logic otherwhere. And before this patch we pass operation timeout in 
callWithoutRetries, which should be rpcTimeout and we get the min(rpcTimeout, 
remainTime) in it.

And we have setRpctimeout and setOperationTimeout in HTable, we should make 
sure if users change timeout by these methods, the timeout settings in 
AP/BufferedMutator are also changed.

Thanks.

> Timeout logic in AsyncProcess is broken
> ---------------------------------------
>
>                 Key: HBASE-16664
>                 URL: https://issues.apache.org/jira/browse/HBASE-16664
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: HBASE-16664-v1.patch, testhcm.patch
>
>
> Have not checked the root cause, but I think timeout of all operations in 
> AsyncProcess is broken



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to