[ https://issues.apache.org/jira/browse/HBASE-16736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545253#comment-15545253 ]
Anoop Sam John commented on HBASE-16736: ---------------------------------------- bq.The setMaxSize() method is changing lruCache only. Hence I make getMaxSize() symmetrical to the setter Ya.. Because changing max size is only applicable for Resizable cache. L1 only comes in that. But any Block Cache is having a max size. Actually u can see getters in LRU cache and Bucket cache already. Only thing is it was not there part of any interface. That is why my Q was. Whether it make more sense to add the getter in BlockCache interface itself. And then comes Q abt Combined cache. The get max size returning only L1 cache size is strange IMO. As such we dont have a clear usage area now, better we dont add it then? > Add getter to ResizableBlockCache for max size > ---------------------------------------------- > > Key: HBASE-16736 > URL: https://issues.apache.org/jira/browse/HBASE-16736 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Ted Yu > Attachments: 16736.v1.txt, 16736.v2.txt, 16736.v3.txt > > > Currently ResizableBlockCache only has one method for setting max size. > As more first level cache type is added, we need the ability to retrieve the > max size. > This issue is to add getter to ResizableBlockCache for retrieving max size. -- This message was sent by Atlassian JIRA (v6.3.4#6332)