[ https://issues.apache.org/jira/browse/HBASE-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547713#comment-15547713 ]
stack commented on HBASE-16758: ------------------------------- +1 I was going to argue that these are not important changes but the change in FanOutOneBlockAsyncDFSOutputSaslHelper.java makes this patch worthwhile I'd say. > Bring back HBaseZeroCopyByteStringer stuff > ------------------------------------------ > > Key: HBASE-16758 > URL: https://issues.apache.org/jira/browse/HBASE-16758 > Project: HBase > Issue Type: Sub-task > Components: Protobufs > Affects Versions: 2.0.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-16758.patch > > > After the shading and moving to 3.x PB, we dont need this. But many a places, > we can not use the shaded classes. (Like > FanOutOneBlockAsyncDFSOutputSaslHelper). In those places it will be better > to go with old way of HBaseZeroCopyByteStringer fix to avoid copy. > Need to see where all we need to do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)