[ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574206#comment-15574206 ]
ramkrishna.s.vasudevan commented on HBASE-16729: ------------------------------------------------ Thanks Stack. bq. if in branch-1, should be off by default. Off by default? How we do this? {code} public static Filter createFilterFromArguments(ArrayList<byte []> filterArguments) { throw new IllegalArgumentException("This method has not been implemented"); } {code} Where is this being used in the code base? Other than this you find any other problem in extending FilterBase. Other than +1. > Define the behavior of (default) empty FilterList > ------------------------------------------------- > > Key: HBASE-16729 > URL: https://issues.apache.org/jira/browse/HBASE-16729 > Project: HBase > Issue Type: Wish > Affects Versions: 2.0.0 > Reporter: ChiaPing Tsai > Assignee: ChiaPing Tsai > Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch > > > Current empty FilterList filters all data, because the > FilterList#isFamilyEssential always returns false which causes the null cell > retrieved by RegionScannerImpl.storeHeap. > It seems to me that empty FilterList should do nothing, because the following > code is common. > {noformat} > private static Filter makeFilter() { > FilterList filterList = new FilterList (); > for (some conditions) { > // add some filters. Or nothing to add. > } > return filterList; > } > {noformat} > If we keep the current logic which filters all data, we should add enough > comments to explain it. Or add the FilterList#size() or FilterList#empty() > for preventing filtering all data. > Any comments? Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)