[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-15789: -------------------------- Resolution: Fixed Hadoop Flags: Reviewed Release Note: Adds means of patching our checked-in protobuf as last part of our offline -Pgenerate-shaded-classes step. Patches found in the new src/main/patches directory are all applied as the last step when you run a build with the -Pgenerate-shaded-classes profile. This commit also includes an actual patch that adds ByteInput to mimic pb3.1's ByteOutput (src/main/patches/HBASE-15789_V2.patch attached here). (was: Adds means of patching our checked-in protobuf as last part of our offline -Pgenerate-shaded-classes step. As part of introduction of the above, it exercises the facility with a protobuf patch to add ByteInput support.) Status: Resolved (was: Patch Available) Pushed to master. Required two commits. Once to add this facility and the patch to pb and then a second commit of changes that are the result of the -Pgenerate-shaded-classes step. > PB related changes to work with offheap > --------------------------------------- > > Key: HBASE-15789 > URL: https://issues.apache.org/jira/browse/HBASE-15789 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Reporter: ramkrishna.s.vasudevan > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-15789.master.001.patch, HBASE-15789.patch, > HBASE-15789_V2.patch > > > This is an issue to brainstorm. Whether we go with pb 2.x or pb 3.0 and also > depends on the shading of protobuf classes. > We should also decide if we are going to fork the PB classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)