[ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578650#comment-15578650 ]
ChiaPing Tsai commented on HBASE-15789: --------------------------------------- [~stack] i get some compile error after committing this issue. The error are shown below. {noformat} [ERROR] /root/hbase/hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/com/google/protobuf/ByteInputByteString.java:[125,34] getOrCreateBuffer(int) has private access in org.apache.hadoop.hbase.shaded.com.google.protobuf.ByteBufferWriter [ERROR] /root/hbase/hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/com/google/protobuf/ByteInputByteString.java:[153,29] incompatible types: org.apache.hadoop.hbase.shaded.com.google.protobuf.ByteInput cannot be converted to byte[] [ERROR] /root/hbase/hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/com/google/protobuf/ByteInputByteString.java:[159,16] no suitable method found for partialIsValidUtf8(int,org.apache.hadoop.hbase.shaded.com.google.protobuf.ByteInput,int,int) method org.apache.hadoop.hbase.shaded.com.google.protobuf.Utf8.partialIsValidUtf8(int,byte[],int,int) is not applicable (argument mismatch; org.apache.hadoop.hbase.shaded.com.google.protobuf.ByteInput cannot be converted to byte[]) method org.apache.hadoop.hbase.shaded.com.google.protobuf.Utf8.partialIsValidUtf8(int,java.nio.ByteBuffer,int,int) is not applicable (argument mismatch; org.apache.hadoop.hbase.shaded.com.google.protobuf.ByteInput cannot be converted to java.nio.ByteBuffer) [ERROR] /root/hbase/hbase-protocol-shaded/src/main/java/org/apache/hadoop/hbase/shaded/com/google/protobuf/ByteInputByteString.java:[247,41] incompatible types: org.apache.hadoop.hbase.shaded.com.google.protobuf.ByteInput cannot be converted to byte[] {noformat} Would you please take a look? Thanks. > PB related changes to work with offheap > --------------------------------------- > > Key: HBASE-15789 > URL: https://issues.apache.org/jira/browse/HBASE-15789 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Reporter: ramkrishna.s.vasudevan > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-15789.master.001.patch, HBASE-15789.patch, > HBASE-15789_V2.patch > > > This is an issue to brainstorm. Whether we go with pb 2.x or pb 3.0 and also > depends on the shading of protobuf classes. > We should also decide if we are going to fork the PB classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)