[jira] [Commented] (HBASE-16786) Procedure V2 - Move ZK-lock's uses to Procedure framework locks (LockProcedure)

[Appy (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-16786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15580792#comment-15580792
 ] 

Appy commented on HBASE-16786:
------------------------------

Tested on a 2 node cluster.
Turned on debugging log for org.apache.hadoop.hbase.master.procedure 
(LockProcedure) and org.apache.hadoop.hbase.zookeeper.lock (removed ZK locks) 
on master, and for org.apache.hadoop.hbase.client on RS.

Tried split, merge, and snapshot.
Here are log snippets.

MASTER SIDE:

For split
{noformat}
2016-10-16 16:56:23,414 DEBUG [ProcedureExecutor-2] procedure.LockProcedure: 
LOCKED - 
org.apache.hadoop.hbase.master.procedure.LockProcedureregions=[b483519eec2363741d93d385c4c80658,],
 level=REGION, type=EXCLUSIVE id=6 owner=root state=RUNNABLE
.....splitting logs....
2016-10-16 16:56:23,516 INFO  
[RpcServer.FifoWFPBQ.default.handler=29,queue=2,port=16000] 
master.RegionStateStore: Updating hbase:meta row 
t,5,1476662183411.55213a2fd15ee64c7ad84ff54c19f6c3. with state=OPEN, 
openSeqNum=1, server=appy-2.vpc.cloudera.com,16020,1476661149567
2016-10-16 16:56:23,523 DEBUG [ProcedureExecutor-3] procedure.LockProcedure: 
UNLOCKED - 
org.apache.hadoop.hbase.master.procedure.LockProcedureregions=[b483519eec2363741d93d385c4c80658,],
 level=REGION, type=EXCLUSIVE id=6 owner=root state=RUNNABLE
{noformat}

For merge
{noformat}
2016-10-16 17:06:38,869 DEBUG [ProcedureExecutor-3] procedure.LockProcedure: 
LOCKED - 
org.apache.hadoop.hbase.master.procedure.LockProcedureregions=[8958d3630516df4bac518faea9db09ce,55213a2fd15ee64c7ad84ff54c19f6c3,],
 level=REGION, type=EXCLUSIVE id=8 owner=root state=RUNNABLE
....other merge regions log....
2016-10-16 17:06:39,923 INFO  
[RpcServer.FifoWFPBQ.default.handler=29,queue=2,port=16000] 
master.RegionStates: Transition {7b208ef804e26f84f8a59d5d850d6300 
state=MERGING_NEW, ts=1476662799833, 
server=appy-2.vpc.cloudera.com,16020,1476661149567} to 
{7b208ef804e26f84f8a59d5d850d6300 state=OPEN, ts=1476662799923, 
server=appy-2.vpc.cloudera.com,16020,1476661149567}
2016-10-16 17:06:39,923 INFO  
[RpcServer.FifoWFPBQ.default.handler=29,queue=2,port=16000] 
master.RegionStateStore: Updating hbase:meta row 
t,2,1476662799821.7b208ef804e26f84f8a59d5d850d6300. with state=OPEN, 
openSeqNum=1, server=appy-2.vpc.cloudera.com,16020,1476661149567
2016-10-16 17:06:39,930 DEBUG [ProcedureExecutor-0] procedure.LockProcedure: 
UNLOCKED - 
org.apache.hadoop.hbase.master.procedure.LockProcedureregions=[8958d3630516df4bac518faea9db09ce,55213a2fd15ee64c7ad84ff54c19f6c3,],
 level=REGION, type=EXCLUSIVE id=8 owner=root state=RUNNABLE
{noformat}

For snapshot (takes lock only for getting table descriptor)
{noformat}
2016-10-16 17:09:55,898 DEBUG [ProcedureExecutor-2] procedure.LockProcedure: 
LOCKED - org.apache.hadoop.hbase.master.procedure.LockProcedurename=t, 
level=TABLE, type=EXCLUSIVE id=9 
owner=org.apache.hadoop.hbase.master.snapshot.EnabledTableSnapshotHandler 
state=RUNNABLE
2016-10-16 17:09:55,899 DEBUG [ProcedureExecutor-1] procedure.LockProcedure: 
UNLOCKED - org.apache.hadoop.hbase.master.procedure.LockProcedurename=t, 
level=TABLE, type=EXCLUSIVE id=9 
owner=org.apache.hadoop.hbase.master.snapshot.EnabledTableSnapshotHandler 
state=RUNNABLE
{noformat}


RS SIDE

For split.
{noformat}
2016-10-16 16:56:23,415 INFO  
[regionserver/appy-2.vpc.cloudera.com/172.26.25.176:16020-splits-1476661525821] 
client.HBaseLock: Acquired lock: lock_level: REGION
lock_type: EXCLUSIVE
region_info {
  region_id: 1476661526014
  table_name {
    namespace: "default"
    qualifier: "t"
  }
  start_key: "2"
  end_key: ""
  offline: false
  split: false
  replica_id: 0
}
description: "SPLIT_REGION: t,2,1476661526014.b483519eec2363741d93d385c4c80658."
nonce_group: 11972038343199202908
nonce: 6801264726420137337
{noformat}

> Procedure V2 - Move ZK-lock's uses to Procedure framework locks 
> (LockProcedure)
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-16786
>                 URL: https://issues.apache.org/jira/browse/HBASE-16786
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-16786.master.001.patch, 
> HBASE-16786.master.002.patch, HBASE-16786.master.003.patch, 
> HBASE-16786.master.004.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)