[ https://issues.apache.org/jira/browse/HBASE-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602118#comment-15602118 ]
Yu Li commented on HBASE-16931: ------------------------------- Checking the UT result and all 3 cases failed because of OOME and irrelative to patch here. {noformat} Running org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient Running org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure Exception in thread "Thread-2421" Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Thread-2415" Running org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure Exception in thread "Thread-2415" java.lang.OutOfMemoryError: Java heap space at java.util.Arrays.copyOf(Arrays.java:3332) at java.lang.AbstractStringBuilder.expandCapacity(AbstractStringBuilder.java:137) at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:121) at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:569) at java.lang.StringBuffer.append(StringBuffer.java:369) at java.io.BufferedReader.readLine(BufferedReader.java:358) at java.io.BufferedReader.readLine(BufferedReader.java:389) at org.apache.maven.surefire.shade.org.apache.maven.shared.utils.cli.StreamPumper.run(StreamPumper.java:66) Exception in thread "Thread-2419" java.lang.OutOfMemoryError: Java heap space Exception in thread "Thread-2423" java.lang.OutOfMemoryError: Java heap space Exception in thread "Thread-2425" java.lang.OutOfMemoryError: Java heap space {noformat} And confirmed all could pass locally. > Setting cell's seqId to zero in compaction flow might cause RS down. > -------------------------------------------------------------------- > > Key: HBASE-16931 > URL: https://issues.apache.org/jira/browse/HBASE-16931 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 2.0.0 > Reporter: binlijin > Assignee: binlijin > Priority: Critical > Attachments: HBASE-16931-master.patch, HBASE-16931.branch-1.patch, > HBASE-16931.branch-1.v2.patch, HBASE-16931_master_v2.patch, > HBASE-16931_master_v3.patch, HBASE-16931_master_v4.patch, > HBASE-16931_master_v5.patch > > > Compactor#performCompaction > do { > hasMore = scanner.next(cells, scannerContext); > // output to writer: > for (Cell c : cells) { > if (cleanSeqId && c.getSequenceId() <= smallestReadPoint) { > CellUtil.setSequenceId(c, 0); > } > writer.append(c); > } > cells.clear(); > } while (hasMore); > scanner.next will choose at most "hbase.hstore.compaction.kv.max" kvs, the > last cell still reference by StoreScanner.prevCell, so if cleanSeqId is > called when the scanner.next call StoreScanner.checkScanOrder may throw > exception and cause regionserver down. -- This message was sent by Atlassian JIRA (v6.3.4#6332)