[
https://issues.apache.org/jira/browse/HBASE-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616962#comment-15616962
]
stack commented on HBASE-16955:
-------------------------------
Got the failure I was expecting post commit of the HBASE-16963 sub-issue:
{code}
============================================================================
============================================================================
HBase protoc plugin: patch
============================================================================
============================================================================
cd /testptch/hbase/hbase-protocol
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1
-DHBasePatchProcess compile -DskipTests -Pcompile-protobuf -X
-DHBasePatchProcess >
/testptch/patchprocess/patch-hbaseprotoc-hbase-protocol.txt 2>&1
Elapsed: 0m 18s
cd /testptch/hbase/hbase-protocol-shaded
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1
-DHBasePatchProcess compile -DskipTests -Pcompile-protobuf -X
-DHBasePatchProcess >
/testptch/patchprocess/patch-hbaseprotoc-hbase-protocol-shaded.txt 2>&1
Elapsed: 0m 5s
cd /testptch/hbase/hbase-spark
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1
-DHBasePatchProcess compile -DskipTests -Pcompile-protobuf -X
-DHBasePatchProcess > /testptch/patchprocess/patch-hbaseprotoc-hbase-spark.txt
2>&1
Elapsed: 0m 34s
hbase-protocol-shaded in the patch failed.
{code}
Failure is because of:
{code}
Snapshot.proto, Tracing.proto, WAL.proto, ZooKeeper.proto, TestProcedure.proto,
test.proto, test_rpc_service.proto]
[DEBUG] (f) source = FileSet {directory:
/testptch/hbase/hbase-protocol-shaded/src/main/protobuf, PatternSet [includes:
{Admin.proto, Cell.proto, Client.proto, ClusterId.proto, ClusterStatus.proto,
Comparator.proto, Encryption.proto, ErrorHandling.proto, FS.proto,
Filter.proto, HBase.proto, HFile.proto, LoadBalancer.proto, MapReduce.proto,
Master.proto, MasterProcedure.proto, Procedure.proto, Quota.proto, RPC.proto,
RegionNormalizer.proto, RegionServerStatus.proto, Snapshot.proto,
Tracing.proto, WAL.proto, ZooKeeper.proto, TestProcedure.proto, test.proto,
test_rpc_service.proto}, excludes: {}]}
[DEBUG] -- end configuration --
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.731s
[INFO] Finished at: Fri Oct 28 23:18:05 UTC 2016
[INFO] Final Memory: 12M/309M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.hadoop:hadoop-maven-plugins:2.7.1:protoc (compile-protoc) on project
hbase-protocol-shaded: org.apache.maven.plugin.MojoExecutionException: protoc
version is 'libprotoc 2.5.0', expected version is '3.1.0' -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.hadoop:hadoop-maven-plugins:2.7.1:protoc (compile-protoc) on project
hbase-protocol-shaded: org.apache.maven.plugin.MojoExecutionException: protoc
version is 'libprotoc 2.5.0', expected version is '3.1.0'
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException:
org.apache.maven.plugin.MojoExecutionException: protoc version is 'libprotoc
2.5.0', expected version is '3.1.0'
at
org.apache.hadoop.maven.plugin.protoc.ProtocMojo.execute(ProtocMojo.java:102)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more
Caused by: org.apache.maven.plugin.MojoExecutionException: protoc version is
'libprotoc 2.5.0', expected version is '3.1.0'
at
org.apache.hadoop.maven.plugin.protoc.ProtocMojo.execute(ProtocMojo.java:70)
... 21 more
[ERROR]
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
{code}
... as expected. Now let me commit HBASE-16952 which is the revamp of how we do
protos generation and it should fix the above.
> Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
> ----------------------------------------------------------------------------
>
> Key: HBASE-16955
> URL: https://issues.apache.org/jira/browse/HBASE-16955
> Project: HBase
> Issue Type: Task
> Components: build, Protobufs
> Reporter: stack
> Assignee: stack
> Attachments: nothing_change.txt, nothing_change2.txt,
> nothing_change2.txt
>
>
> HBASE-15638 Shade protobuf and a follow-ons changed how we do protobufs.
> One, protobufs are in the module they pertain to so distributed throughout
> the modules and secondly, we do 2.5.0 pb for externally consumed protobuf --
> e.g. Coprocessor Endpoints -- but internally we use protobuf 3.1.0.
> A precommit check looks to see if any proto changes break protoc compile.
> This task is about updating the precommit to accommodate the changes brought
> about by HBASE-15638.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
