[
https://issues.apache.org/jira/browse/HBASE-16964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634395#comment-15634395
]
Hudson commented on HBASE-16964:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-1.4 #513 (See
[https://builds.apache.org/job/HBase-1.4/513/])
HBASE-16964 Always clear successfully archived files from compacted (garyh: rev
4fe51ebaa794131d7e3e2a042ba85f9d525726c2)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (add)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveIOException.java
* (add)
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/FailedArchiveException.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MockStoreFile.java
> Successfully archived files are not cleared from compacted store file list if
> archiving of any file fails
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-16964
> URL: https://issues.apache.org/jira/browse/HBASE-16964
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Blocker
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: HBASE-16964.002.patch, HBASE-16964.003.patch,
> HBASE-16964.patch
>
>
> In HStore.removeCompactedFiles(), we only clear archived files from
> StoreFileManager's list of compactedfiles if _all_ files were archived
> successfully. If we encounter an error archiving any of the files, then any
> files which were already archived will remain in the list of compactedfiles.
> Even worse, this means that all subsequent attempts to archive the list of
> compacted files will fail (as the previously successfully archived files
> still in the list will now throw FileNotFoundException), and the list of
> compactedfiles will never be cleared from that point on.
> Finally, when the region closes, we will again throw an exception out of
> HStore.removeCompactedFiles(), in this case causing a regionserver abort.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
