[ 
https://issues.apache.org/jira/browse/HBASE-17010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636845#comment-15636845
 ] 

Ted Yu commented on HBASE-17010:
--------------------------------

{code}
+  public static Put makeSerialParentPut(byte[] encodedRegionName, byte[] 
value) {
{code}
'Serial' in the method name is not needed. Same with makeSerialDaughterPut.
{code}
+   * Get parent region(s) for a region, only used in serial replication.
+   * @throws IOException
{code}
Add javadoc for @param and @return
{code}
+  /** The replication meta family as a string*/
+  public static final String REPLICATION_META_FAMILY_STR = "rep_meta";
{code}
Looks like we should create ReplicationConstants.java :-) (doesn't have to be 
done in this JIRA)
{code}
+      while (true) {
+        boolean allParentDone = true;
{code}
There is no limit for the duration of the loop ?



> Serial replication should handle daughter regions being assigned to another RS
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-17010
>                 URL: https://issues.apache.org/jira/browse/HBASE-17010
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Phil Yang
>         Attachments: HBASE-17010-v1.patch
>
>
> testRegionSplit and testRegionMerge were temporarily disabled by HBASE-16975.
> HBASE-9465 has an assumption that when we split a region, two daughter 
> regions are in same RS with the parent region. But after HBASE-14551 went in, 
> daughter regions may be assigned to other RS directly.  
> This issue is to handle the new behavior and reenable the tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to