[ https://issues.apache.org/jira/browse/HBASE-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656680#comment-15656680 ]
Yu Li commented on HBASE-17058: ------------------------------- Patch lgtm, +1. Epsilon is a more careful way to check whether a double equals to zero and no need for greater/less check. Thanks for the fix [~esteban]. > Lower epsilon used for jitter verification from HBASE-15324 > ----------------------------------------------------------- > > Key: HBASE-17058 > URL: https://issues.apache.org/jira/browse/HBASE-17058 > Project: HBase > Issue Type: Bug > Components: Compaction > Affects Versions: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4 > Reporter: Esteban Gutierrez > Assignee: Esteban Gutierrez > Attachments: HBASE-17058.master.001.patch > > > The current epsilon used is 1E-6 and its too big it might overflow the > desiredMaxFileSize. A trivial fix is to lower the epsilon to 2^-52 or even > 2^-53. An option to consider too is just to shift the jitter to always > decrement hbase.hregion.max.filesize (MAX_FILESIZE) instead of increase the > size of the region and having to deal with the round off. -- This message was sent by Atlassian JIRA (v6.3.4#6332)