[ https://issues.apache.org/jira/browse/HBASE-16870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667731#comment-15667731 ]
Hudson commented on HBASE-16870: -------------------------------- FAILURE: Integrated in Jenkins build HBase-0.98-on-Hadoop-1.1 #1289 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1289/]) HBASE-16870 Add the metrics of replication sources which were (apurtell: rev 99798411e537007a3a12795f945c431081bc1c34) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStatus.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationLoad.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java > Add the metrics of replication sources which were transformed from other dead > rs to ReplicationLoad > --------------------------------------------------------------------------------------------------- > > Key: HBASE-16870 > URL: https://issues.apache.org/jira/browse/HBASE-16870 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 2.0.0, 1.4.0, 1.2.3, 1.1.7 > Reporter: Guanghao Zhang > Assignee: Guanghao Zhang > Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.2.4, 0.98.24, 1.1.8 > > Attachments: HBASE-16870-ADDENDUM-v1.patch, > HBASE-16870-ADDENDUM.patch, HBASE-16870-branch-1-v1.patch, > HBASE-16870-branch-1-v1.patch, HBASE-16870-branch-1.1-v1.patch, > HBASE-16870-branch-1.1-v1.patch, HBASE-16870-branch-1.1.patch, > HBASE-16870-branch-1.3-v1.patch, HBASE-16870-branch-1.3-v1.patch, > HBASE-16870-branch-1.3.patch, HBASE-16870-branch-1.patch, > HBASE-16870-v1.patch, HBASE-16870.patch > > > {code} > private void buildReplicationLoad() { > // get source > List<ReplicationSourceInterface> sources = > this.replicationManager.getSources(); > List<MetricsSource> sourceMetricsList = new ArrayList<MetricsSource>(); > for (ReplicationSourceInterface source : sources) { > if (source instanceof ReplicationSource) { > sourceMetricsList.add(((ReplicationSource) > source).getSourceMetrics()); > } > } > // get sink > MetricsSink sinkMetrics = this.replicationSink.getSinkMetrics(); > this.replicationLoad.buildReplicationLoad(sourceMetricsList, sinkMetrics); > } > {code} > The buildReplicationLoad method in o.a.h.h.r.r.Replication didn't consider > the replication source which were transformed from other died rs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)