[
https://issues.apache.org/jira/browse/HBASE-16912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685766#comment-15685766
]
Sean Busbey commented on HBASE-16912:
-------------------------------------
(patch submission is going to fail since the latest file is the review file)
this looks great! I'd like to reformat the commit message before commit to
ensure there's an initial summary line that fits in ~80 characters.
{code}
+
+ @Override
+ public HRegionInfo getRegionInfoForFS() {
uagashe>>> getRegionInfoForStorage instead?
+ return regionInfoForFs;
+ }
}
{code}
Seeing this here is reminding me that probably the method in RegionStorage
should be something like {{getRegionInfoFromStorage}} rather than this
reference to FS.
{code}
}
HRegionInfo info = new HRegionInfo(tableName, null, null, false);
- Path path = new Path(DIR + callingMethod);
uagashe>>> should callingMethod still be used as a root directory to give
separate area for each caller?
- Region r = HBaseTestingUtility.createRegionAndWAL(info, path, conf, htd);
+ Region r = TEST_UTIL.createLocalHRegion(info, htd, conf);
{code}
Personally, I like the move to {{createLocalHRegion}} since it means we can
place things in random directories if needed for isolation without relying on
the caller to know that we need something like a {{callingMethod}} variable.
{code}
- Region region = HBaseTestingUtility.createRegionAndWAL(hri, path, conf,
htd);
uagashe>>> should we destroyRegion to clean up after previously aborted test,
before we begin with new?
+ Region region = htu.createLocalHRegion(hri, htd);
{code}
If cleaning up after aborted tests is needed, it should happen in an @after
block for junit rather than in a test.
> TEST: update HBaseTestingUtility to avoid direct use of filesystem / legacy
> implementation
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-16912
> URL: https://issues.apache.org/jira/browse/HBASE-16912
> Project: HBase
> Issue Type: Sub-task
> Components: Filesystem Integration
> Affects Versions: hbase-14439
> Reporter: Sean Busbey
> Assignee: Appy
> Fix For: hbase-14439
>
> Attachments: HBASE-16912.hbase-14439.001.patch,
> HBASE-16912.hbase-14439.002.patch, HBASE-16912.hbase-14439.002.review,
> fs-redo-HBTU.patch
>
>
> Update the HBaseTestingUtility to ensure it relies on MasterStorage /
> RegionStorage APIs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
