[
https://issues.apache.org/jira/browse/HBASE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168752#comment-13168752
]
jirapos...@reviews.apache.org commented on HBASE-4605:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2579/
-----------------------------------------------------------
(Updated 2011-12-13 21:38:03.559611)
Review request for hbase.
Changes
-------
Making changes as per last comments on last diff:
1) Removing copywrite lines
2) Adding test categorization
3) Removing guava from HTD
4) Serializing conf to xml
5) Moving integerConstraint to package-info
Summary
-------
Most of the implementation for adding constraints as a coprocessor.
Looking for general comments on style/structure, though nitpicks are ok too.
Currently missing implementation for disableConstraints() since that will
require adding removeCoprocessor() to HTD (also comments on if this is worth it
would be good).
This addresses bug HBASE-4605.
https://issues.apache.org/jira/browse/HBASE-4605
Diffs (updated)
-----
src/docbkx/book.xml 9617950
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java 84a0d1a
src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/constraint/ConstraintException.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/constraint/ConstraintProcessor.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/constraint/package-info.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/constraint/AllFailConstraint.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/constraint/AllPassConstraint.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/constraint/RuntimeFailConstraint.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/constraint/TestConstraints.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/constraint/WorksConstraint.java
PRE-CREATION
Diff: https://reviews.apache.org/r/2579/diff
Testing
-------
Adding IntegrationTestConstraint and unit tests for Constraints and
IntegerConstraint. All of those pass.
Thanks,
Jesse
> Constraints
> -----------
>
> Key: HBASE-4605
> URL: https://issues.apache.org/jira/browse/HBASE-4605
> Project: HBase
> Issue Type: Improvement
> Components: client, coprocessors
> Affects Versions: 0.94.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: 4605.v7, constraint_as_cp.txt, java_Constraint_v2.patch,
> java_HBASE-4605_v1.patch, java_HBASE-4605_v2.patch, java_HBASE-4605_v3.patch
>
>
> From Jesse's comment on dev:
> {quote}
> What I would like to propose is a simple interface that people can use to
> implement a 'constraint' (matching the classic database definition). This
> would help ease of adoption by helping HBase more easily check that box, help
> minimize code duplication across organizations, and lead to easier adoption.
> Essentially, people would implement a 'Constraint' interface for checking
> keys before they are put into a table. Puts that are valid get written to the
> table, but if not people can will throw an exception that gets propagated
> back to the client explaining why the put was invalid.
> Constraints would be set on a per-table basis and the user would be expected
> to ensure the jars containing the constraint are present on the machines
> serving that table.
> Yes, people could roll their own mechanism for doing this via coprocessors
> each time, but this would make it easier to do so, so you only have to
> implement a very minimal interface and not worry about the specifics.
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
