[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168828#comment-13168828 ]
jirapos...@reviews.apache.org commented on HBASE-4895: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3188/#review3892 ----------------------------------------------------------- When I scan, I'll see uuids. How do I go from uuid to tablename as I ask in below? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java <https://reviews.apache.org/r/3188/#comment8750> This uuid type 3 will be same no matter what machine or time (it looks like it but asking if you verified) One day we should add to Bytes a Bytes.toBytes that takes a uuid src/main/java/org/apache/hadoop/hbase/HRegionInfo.java <https://reviews.apache.org/r/3188/#comment8751> Whats this here? UUID tablename? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java <https://reviews.apache.org/r/3188/#comment8752> Is this tablename or uuid? Don't you have to deprecate the old method rather than just drop it? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java <https://reviews.apache.org/r/3188/#comment8753> How do I go from uuid of tablename back to tablename? I don't see it. src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java <https://reviews.apache.org/r/3188/#comment8755> Whats going on here? The other patch adds this file. So it has to go in first? - Michael On 2011-12-13 21:13:46, Alex Newman wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3188/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-12-13 21:13:46) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. PART 2 of hbase-4616 bq. bq. By uuiding the tablename in the metarow, it enables us to be able to use binary values for the end of table marker bq. bq. bq. This addresses bug HBASE-4895. bq. https://issues.apache.org/jira/browse/HBASE-4895 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 bq. src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 bq. src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd bq. src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502 bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b bq. src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 bq. src/test/ruby/hbase/admin_test.rb 0c2672b bq. bq. Diff: https://reviews.apache.org/r/3188/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Alex bq. bq. > Change tablename format in meta to be the UUID of the tablename rather than > the tablename. > ------------------------------------------------------------------------------------------ > > Key: HBASE-4895 > URL: https://issues.apache.org/jira/browse/HBASE-4895 > Project: HBase > Issue Type: Sub-task > Reporter: Alex Newman > Assignee: Alex Newman > Attachments: 0002-Moved-to-a-uuid-tablename.patch > > > This is something stack and I discussed at hadoop world. Overall I think it > cleans thing up significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira