[ 
https://issues.apache.org/jira/browse/HBASE-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702428#comment-15702428
 ] 

ramkrishna.s.vasudevan commented on HBASE-17081:
------------------------------------------------

Am not sure why the current way is problematic. The only thing is that cellSet 
will be null in this impl. And where ever we have the need for cellSet I think 
the Composite impl is not going to use it directly. So it is fine IMHO.
If getCellSet() is the problem then I think it can be easily avoided because 
the only place it is exposed in the Memstore and its subclasses is in 
getNextRow() and that is only for test cases. Rest if you see it is only used 
in Segments and in subclasses for which we don't need that getter and directly 
we could access the cellSet in its subclasses.

> Flush the entire CompactingMemStore content to disk
> ---------------------------------------------------
>
>                 Key: HBASE-17081
>                 URL: https://issues.apache.org/jira/browse/HBASE-17081
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>            Assignee: Anastasia Braginsky
>         Attachments: HBASE-17081-V01.patch, HBASE-17081-V02.patch, 
> HBASE-17081-V03.patch, Pipelinememstore_fortrunk_3.patch
>
>
> Part of CompactingMemStore's memory is held by an active segment, and another 
> part is divided between immutable segments in the compacting pipeline. Upon 
> flush-to-disk request we want to flush all of it to disk, in contrast to 
> flushing only tail of the compacting pipeline.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to