[ https://issues.apache.org/jira/browse/HBASE-17235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714458#comment-15714458 ]
ramkrishna.s.vasudevan commented on HBASE-17235: ------------------------------------------------ bq.Now if and else block both need this enableAliasing call and so put it outside. Oh. I added that changed. Then I took and update and then prepared the patch that time missed it. Will and commit it. thanks for the review. Will raise a new JIRa for the other part. > Improvement in creation of CIS for onheap buffer cases > ------------------------------------------------------ > > Key: HBASE-17235 > URL: https://issues.apache.org/jira/browse/HBASE-17235 > Project: HBase > Issue Type: Improvement > Components: rpc > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-17235.patch > > > {code} > if (buf.hasArray()) { > cis = CodedInputStream.newInstance(buf.array(), offset, buf.limit()); > } else { > {code} > Currently we do this for onheap buffers incase there is no reservoir or the > size is less than the minSizeforReservoir. I could see that even if reservoir > is there there are requests which goes with the above way of creating CIS. > This could be made efficient to avoid underlying copies by just doing this > {code} > cis = UnsafeByteOperations.unsafeWrap(buf.array(), offset, > buf.limit()).newCodedInput(); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)