[ https://issues.apache.org/jira/browse/HBASE-17239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724482#comment-15724482 ]
ramkrishna.s.vasudevan commented on HBASE-17239: ------------------------------------------------ Yes will do it then. Thanks Stack. > Add UnsafeByteOperations#wrap(ByteInput, int offset, int len) API > ----------------------------------------------------------------- > > Key: HBASE-17239 > URL: https://issues.apache.org/jira/browse/HBASE-17239 > Project: HBase > Issue Type: Improvement > Components: Protobufs > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: HBASE-17239.addendum.patch, HBASE-17239_V1.patch, > HBASE-17239_V2.patch, HBASE-17239_V3.patch > > > Instead of exposing the newInstance(ByteInput, boolean) in CIS we could just > add a UnsafeByteOperations#wrap(ByteInput, offset, len). And we could just > call that and do a #newcodedInput() over that. So internally we do return a > immutable version of the ByteInput only. This way we can avoid > CIS#newInstance(ByteInput) exposure and can keep it package private as done > in COS. -- This message was sent by Atlassian JIRA (v6.3.4#6332)