[
https://issues.apache.org/jira/browse/HBASE-17051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755708#comment-15755708
]
Enis Soztutar commented on HBASE-17051:
---------------------------------------
Nvm, I think this:
{code}
std::shared_ptr<RpcChannel> RpcClient::CreateRpcChannel(const std::string &host,
uint16_t port, std::shared_ptr<User> ticket, int rpc_timeout) {
auto channel = new RpcChannelImplementation(shared_from_this(), host, port,
ticket, rpc_timeout);
return std::make_shared<RpcChannel>(channel);
}
{code}
should be:
{code}
std::shared_ptr<RpcChannel> RpcClient::CreateRpcChannel(const std::string &host,
uint16_t port, std::shared_ptr<User> ticket, int rpc_timeout) {
return std::make_shared<RpcChannelImplementation>(shared_from_this(),
host, port, ticket, rpc_timeout);
}
{code}
Let me attach a patch.
> libhbase++: implement RPC client and connection management
> ----------------------------------------------------------
>
> Key: HBASE-17051
> URL: https://issues.apache.org/jira/browse/HBASE-17051
> Project: HBase
> Issue Type: Sub-task
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HBASE-17051-HBASE-14850.000.patch,
> HBASE-17051-HBASE-14850.001.patch, HBASE-17051-HBASE-14850.002.patch,
> HBASE-17051-HBASE-14850.003.patch, HBASE-17051-HBASE-14850.004.patch,
> HBASE-17051-HBASE-14850.005.patch
>
>
> This proposes building RPC client and connection management layer, which
> supports the equivalent functions resides in RpcClient.java and
> RpcConnection.java. Specifically, handler/pipeline concepts will be used for
> implementation, similar to NettyRpcClient and NettyRpcConnection in java side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
