[ 
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768204#comment-15768204
 ] 

Jerry He commented on HBASE-16010:
----------------------------------

Hi, [~enis]

bq. I think we should have the ACL changes in this patch as well. Otherwise, it 
will get forgotten and leave a security hole
We surely need to get the ACL in.  But let's get this JIRA with the protobuf 
changes in first?  Mixing the ACL observers and the protobuf changes will 
probably bloat the patch and confusing.
Let me open a subtask right away and make sure it will be in.

Currently, the decommission works this way (i played with it recently.)
1. Put the server in drain mode.
2  Move the regions off with the region mover.

You think we should combine the two steps into one?

bq. "decommissioning" a server should be integral to the new assignment manager 
in the sense that the core assignment should be aware of decommissioning 
servers. 
I think currently if a server is in drain mode, 
serverManager/assignment/balancer will skip it as candidate servers.  But not 
sure much about the details.

> Put draining function through Admin API
> ---------------------------------------
>
>                 Key: HBASE-16010
>                 URL: https://issues.apache.org/jira/browse/HBASE-16010
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jerry He
>            Assignee: Matt Warhaftig
>            Priority: Minor
>         Attachments: hbase-16010-v1.patch, hbase-16010-v2.patch
>
>
> Currently, there is no Amdin API for draining function. Client has to 
> interact directly with Zookeeper draining node to add and remove draining 
> servers.
> For example, in draining_servers.rb:
> {code}
>   zkw = org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.new(config, 
> "draining_servers", nil)
>   parentZnode = zkw.drainingZNode
>   begin
>     for server in servers
>       node = ZKUtil.joinZNode(parentZnode, server)
>       ZKUtil.createAndFailSilent(zkw, node)
>     end
>   ensure
>     zkw.close()
>   end
> {code}
> This is not good in cases like secure clusters with protected Zookeeper nodes.
> Let's put draining function through Admin API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to