[ 
https://issues.apache.org/jira/browse/HBASE-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171183#comment-13171183
 ] 

Zhihong Yu commented on HBASE-5056:
-----------------------------------

0.90 has the same code:
{code}
      instanceObj = new NullInstance(declClass, conf);
{code}
So I guess this wouldn't explain the difference in performance.
                
> [performance] On upload, 4% of memory allocations are NullInstance
> ------------------------------------------------------------------
>
>                 Key: HBASE-5056
>                 URL: https://issues.apache.org/jira/browse/HBASE-5056
>             Project: HBase
>          Issue Type: Improvement
>          Components: performance
>            Reporter: stack
>              Labels: noob
>         Attachments: NullInstanceHotSpotMemAllocation.html
>
>
> Profiling a PE upload, I see that 4% of memory allocations are instances of 
> NullInstance (caveat profiler's give distorted view of running app as does PE 
> when it comes to real-world workloads).  See attached profiler output.  Looks 
> like we could save a bunch on object creation if we had our own 
> WritableFactories instance that treated stuff like NullInstance special 
> creating a Singleton NullInstance per declared class type returning these 
> instead of creating new ones.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to