[ 
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813759#comment-15813759
 ] 

Sudeep Sunthankar commented on HBASE-17315:
-------------------------------------------

Thanks [~enis]

{quote}
{code}
hbase::TestUtil *test_util = new hbase::TestUtil();
..
+  delete test_util;
{code}
{quote}
There was a feedback in one of the earlier issues, not to include smart 
pointers in test cases, hence I refrained from it.

{quote}
{code}
 // ASSERT_TRUE(table != nullptr) << "Unable to get connection to Table.";
{code}
{quote}
Since we moved, it from unique_ptr to return by value, I had commented out the 
part. 
I will be uncomment it in the next patch and also include changes for 
RequestConverter and ResponseConverter classes.

> [C++] HBase Client and Table Implementation
> -------------------------------------------
>
>                 Key: HBASE-17315
>                 URL: https://issues.apache.org/jira/browse/HBASE-17315
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-17315.HBASE-14850.v1.patch, 
> HBASE-17315.HBASE-14850.v2.patch, HBASE-17315.HBASE-14850.v3.patch, 
> HBASE-17315.HBASE-14850.v4.patch, HBASE-17315.HBASE-14850.v5.patch
>
>
> Consists of Client and Table implementation which will be used to call the 
> corresponding client methods i.e Get, Gets, Scan etc. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to