[ https://issues.apache.org/jira/browse/HBASE-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840223#comment-15840223 ]
stack commented on HBASE-17515: ------------------------------- Suggest no need of a revert of [~timbrown] patch. He did what he was asked under guidance and there is likely some benefit -- if unknown. Comments here by me could make for new issues -- but don't file them unless you intend to work on them or if they have no substance beyond 'We should...' -- bit they are more for you to consider going forward; less quick fix, more depth, and be more careful with our contributors time. Thanks. > Reduce memory footprint of RegionLoads kept by StochasticLoadBalancer > --------------------------------------------------------------------- > > Key: HBASE-17515 > URL: https://issues.apache.org/jira/browse/HBASE-17515 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Tim Brown > Attachments: 17515.branch-1.v2.txt, 17515.v1.txt, 17515.v2.txt > > > Currently StochasticLoadBalancer uses the following fields of RegionLoad : > {code} > return rl.getReadRequestsCount(); > return rl.getWriteRequestsCount(); > return rl.getMemStoreSizeMB(); > return rl.getStorefileSizeMB(); > {code} > However, RegionLoad refers to ClusterStatusProtos.RegionLoad which has 18 > fields. > This means we keep hbase.master.balancer.stochastic.numRegionLoadsToRemember > (default value 15) RegionLoad's in memory but only use a small portion of > them. > This JIRA is to consider creating POJO which wraps the above 4 fields so that > the memory footprint can be lowered. > Lowering memory footprint would allow wider sliding window to be configured > for load balancer while limiting the impact to heap consumption. -- This message was sent by Atlassian JIRA (v6.3.4#6332)