[
https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843587#comment-15843587
]
Xiaobing Zhou edited comment on HBASE-17465 at 1/27/17 10:28 PM:
-----------------------------------------------------------------
Thank you [~enis] for reviews.
# HBaseRpcController extends google::protobuf::RpcController
# We need <REQ, PREQ, PRESP, RESP> in SingleRequestCallerBuilder,
AsyncRpcRetryingCallerFactory and AsyncSingleRequestRpcRetryingCaller to make
generic Callable, i.e. hase::Callable<REQ, PREQ, PRESP, RESP>. We will see how
to bridge this with RawAsyncTableImpl in follow-up work.
# conn_ -> get_rpc_controller_factory()->NewController(); actually instantiate
HBaseRpcController by contracting with generic Connection.
For your other comments, I will cover them in refactoring or follow-up work.
I will focus on adding unit tests in upcoming patches.
was (Author: xiaobingo):
Thank you [~enis] for reviews.
# HBaseRpcController extends google::protobuf::RpcController
# We need <REQ, PREQ, PRESP, RESP> in SingleRequestCallerBuilder,
AsyncRpcRetryingCallerFactory and AsyncSingleRequestRpcRetryingCaller to make
generic Callable, i.e. hase::Callable<REQ, PREQ, PRESP, RESP>. We will see how
to bridge this with RawAsyncTableImpl in follow-up work.
# conn_->get_rpc_controller_factory()->NewController(); actually instantiate
HBaseRpcController by contracting with generic Connection.
For your other comments, I will cover them in refactoring or follow-up work.
I will focus on adding unit tests in upcoming patches.
> [C++] implement request retry mechanism over RPC
> ------------------------------------------------
>
> Key: HBASE-17465
> URL: https://issues.apache.org/jira/browse/HBASE-17465
> Project: HBase
> Issue Type: Sub-task
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HBASE-17465-HBASE-14850.000.patch,
> HBASE-17465-HBASE-14850.001.patch, HBASE-17465-HBASE-14850.002.patch,
> HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch,
> HBASE-17465-HBASE-14850.005.patch
>
>
> HBASE-17051 implemented RPC layer. Requests retries will make system
> reliable. This JIRA proposes adding it, which corresponds to similar
> implementation in SingleRequestCallerBuilder (or BatchCallerBuilder,
> ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and
> AsyncSingleRequestRpcRetryingCaller. As a bonus, retry should be more
> generic, decoupled with HRegionLocation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
