[ 
https://issues.apache.org/jira/browse/HBASE-5021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172962#comment-13172962
 ] 

Phabricator commented on HBASE-5021:
------------------------------------

nspiegelberg has commented on the revision "[jira] [HBase-5021] Enforce upper 
bound on timestamp".

  thanks for all the comments :)

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:2147 going to 
default the slop to LATEST_TIMESTAMP, so this problem is no longer a worry.
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:2230-2231 now 
defaults to ms in an unix system.
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:404 changing 
to LATEST_TIMESTAMP, which is Long.MAX_VALUE and also solves the 
updateKVTimestamps() problem

REVISION DETAIL
  https://reviews.facebook.net/D849

                
> Enforce upper bound on timestamp
> --------------------------------
>
>                 Key: HBASE-5021
>                 URL: https://issues.apache.org/jira/browse/HBASE-5021
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Critical
>             Fix For: 0.94.0
>
>         Attachments: D849.1.patch, D849.2.patch
>
>
> We have been getting hit with performance problems on our time-series 
> database due to invalid timestamps being inserted by the timestamp.  We are 
> working on adding proper checks to app server, but production performance 
> could be severely impacted with significant recovery time if something slips 
> past.  Since timestamps are considered a fundamental part of the HBase schema 
> & multiple optimizations use timestamp information, we should allow the 
> option to sanity check the upper bound on the server-side in HBase.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to