[
https://issues.apache.org/jira/browse/HBASE-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872288#comment-15872288
]
Appy commented on HBASE-17654:
------------------------------
bq. Tests failed.
will be tackling them.
bq. I think Closeable is already removed?
i think so. what's the reference?
bq. There is already a Utility class for rsgroup called Utility so RSGroupUtil
clashes. Leave as it was?
yeah, i feel like merging the two, but that gives bad feeling since util class
just tend to overgrow over time. So let me revert this rename for now and let
it be.
bq. How does RSGroupStartupWorker get an instance of masterServices now it does
not take it in constructor.
Since it's an internal class and only makes sense in the context of a manager,
we can make it non-static i guess.
bq. Any reason to change the ServerEventsListenerThread so it listened on
events instead? (I'd rather get rid of that thread if we could).
Yes, in fact i consider it as one of the nicer changes. So 1) no reason why
ManagerImpl should implement the interface directly 2) we can't get rid of the
thread, to that end, i added a comment to ServerEventsListenerThread class. 3)
it encapsulates all listener functionality in single place.
Will update review board in a bit.
> RSGroup code refactoring
> ------------------------
>
> Key: HBASE-17654
> URL: https://issues.apache.org/jira/browse/HBASE-17654
> Project: HBase
> Issue Type: Improvement
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-17654.master.001.patch,
> HBASE-17654.master.002.patch, HBASE-17654.master.003.patch
>
>
> TBD
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
