[
https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874036#comment-15874036
]
Phil Yang commented on HBASE-17210:
-----------------------------------
bq. I don't see assertion in new test. What is the behavior of the test without
fix ?
It will throws an exception because of timeout. Will add a comment in next
patch.
bq. Please change printStackTrace to LOG.
The test should fail if it catch exceptions there.
bq. Client RPC timeout is normally set quite long
In some online services the timeout may be only less than one second. So
default lock timeout is too long for them. This issue is mainly to reduce the
waiting time for acquiring locks to prevent handlers in RS being occupied by
requests that are already considered as timeout at client.
> Set timeout on trying rowlock according to client's RPC timeout
> ---------------------------------------------------------------
>
> Key: HBASE-17210
> URL: https://issues.apache.org/jira/browse/HBASE-17210
> Project: HBase
> Issue Type: Sub-task
> Reporter: Phil Yang
> Assignee: Phil Yang
> Attachments: HBASE-17120.v1.patch, HBASE-17210.v02.patch,
> HBASE-17210.v03.patch
>
>
> Now when we want to get a row lock, the timeout is fixed and default is 30s.
> But the requests from client have different RPC timeout setting. We can use
> the client's deadline to set timeout on tryLock.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
