[jira] [Updated] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort

[Sean Busbey (JIRA)]

     [ 
https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-17677:
--------------------------------
       Resolution: Fixed
    Fix Version/s: 1.1.10
                   1.2.5
                   1.3.1
                   1.4.0
           Status: Resolved  (was: Patch Available)

Thanks for the quick review [~saint....@gmail.com].

FYI, I pushed just the tests back to branch-1.1+, so setting fix versions 
appropriately.

> ServerName parsing from directory name should be more robust to errors from 
> guava's HostAndPort
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17677
>                 URL: https://issues.apache.org/jira/browse/HBASE-17677
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>             Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10
>
>         Attachments: HBASE-17677.1.patch
>
>
> our internal Address facade over HostAndPort directly passes on any failures 
> from the underlying Guava implementation. Right now when we parse a 
> ServerName from a WAL directory we properly handle if guava gives us an 
> IllegalArgumentException but we do not handle if it gives us a 
> IllegalStateException. e.g. it uses the former for "I couldn't parse anything 
> out of this string" and the latter for "I parsed a host name but didn't see a 
> port".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)