[ 
https://issues.apache.org/jira/browse/HBASE-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173777#comment-13173777
 ] 

Zhihong Yu commented on HBASE-5009:
-----------------------------------

How long would the loop below take ?
{code}
+        while (!threadPool.isTerminated()) {
+          Thread.sleep(50);
+        }
         throw new IOException("Took too long to split the" +
             " files and create the references, aborting split");
{code}
I think with the above loop, at least the message in the IOE should be changed 
because the splitting may take much longer than this.fileSplitTimeout ms.
Should we introduce another timeout for the new loop :-)
                
> Failure of creating split dir if it already exists prevents splits from 
> happening further
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-5009
>                 URL: https://issues.apache.org/jira/browse/HBASE-5009
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.6
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-5009.patch, HBASE-5009_Branch90.patch
>
>
> The scenario is
> -> The split of a region takes a long time
> -> The deletion of the splitDir fails due to HDFS problems.
> -> Subsequent splits also fail after that.
> {code}
> private static void createSplitDir(final FileSystem fs, final Path splitdir)
>   throws IOException {
>     if (fs.exists(splitdir)) throw new IOException("Splitdir already exits? " 
> + splitdir);
>     if (!fs.mkdirs(splitdir)) throw new IOException("Failed create of " + 
> splitdir);
>   }
> {code}
> Correct me if am wrong? If it is an issue can we change the behaviour of 
> throwing exception?
> Pls suggest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to