[ https://issues.apache.org/jira/browse/HBASE-17717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893341#comment-15893341 ]
Hadoop QA commented on HBASE-17717: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 11m 41s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 32s {color} | {color:green} 0.98 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 15s {color} | {color:green} 0.98 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s {color} | {color:green} 0.98 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 24s {color} | {color:green} 0.98 passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 51s {color} | {color:red} hbase-client in 0.98 has 16 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s {color} | {color:green} 0.98 passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 9s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 31s {color} | {color:green} The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 10s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 2s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 15s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 11s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 33m 49s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:ef91163 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12855725/HBASE-17717.001.0.98.patch | | JIRA Issue | HBASE-17717 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2da96f055c22 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/hbase.sh | | git revision | 0.98 / f30a654 | | Default Java | 1.7.0_80 | | findbugs | v2.0.1 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/5923/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/5923/testReport/ | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5923/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Incorrect ZK ACL set for HBase superuser > ---------------------------------------- > > Key: HBASE-17717 > URL: https://issues.apache.org/jira/browse/HBASE-17717 > Project: HBase > Issue Type: Bug > Components: security, Zookeeper > Reporter: Shreya Bhat > Assignee: Josh Elser > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.1.10, 1.2.6 > > Attachments: HBASE-17717.001.0.98.patch, > HBASE-17717.001.branch-1.1.patch, HBASE-17717.001.patch > > > Shreya was doing some testing of a deploy of HBase, verifying that the ZK > ACLs were actually set as we expect (yay, security). > She noticed that, in some cases, we were seeing multiple ACLs for the same > user. > {noformat} > 'world,'anyone > : r > 'sasl,'hbase > : cdrwa > 'sasl,'hbase > : cdrwa > {noformat} > After digging into this (and some insight from the mighty [~enis]), we > realized that this was happening because of an overridden value for > {{hbase.superuser}}. However, the ACL value doesn't match what we'd expect to > see (as hbase.superuser was set to {{cstm-hbase}}). > After digging into this code, it seems like the {{auth}} ACL scheme in > ZooKeeper does not work as we expect. > {code} > if (superUser != null) { > acls.add(new ACL(Perms.ALL, new Id("auth", superUser))); > } > {code} > In the above, the {{"auth"}} scheme ignores any provided "subject" in the > {{Id}} object. It *only* considers the authentication of the current > connection. As such, our usage of this never actually sets the ACL for the > superuser correctly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)