[ https://issues.apache.org/jira/browse/HBASE-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895485#comment-15895485 ]
Hadoop QA commented on HBASE-17732: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 24s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 18s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 50s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 26s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 7s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 7s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 50s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 26s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 34m 43s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 9s {color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 23s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 47m 14s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 103m 11s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hbase-server | | | Uncallable method org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$5.postEnvCall(RegionCoprocessorHost$RegionEnvironment) defined in anonymous class At RegionCoprocessorHost.java:anonymous class At RegionCoprocessorHost.java:[lines 493-494] | | Failed junit tests | hadoop.hbase.filter.TestDependentColumnFilter | | | hadoop.hbase.coprocessor.TestCoprocessorInterface | | | hadoop.hbase.regionserver.TestWALMonotonicallyIncreasingSeqId | | | hadoop.hbase.regionserver.TestHRegionFileSystem | | | hadoop.hbase.master.locking.TestLockManager | | | hadoop.hbase.master.locking.TestLockProcedure | | | hadoop.hbase.coprocessor.TestRegionObserverStacking | | | hadoop.hbase.filter.TestFilter | | | hadoop.hbase.filter.TestInvocationRecordFilter | | | hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan | | | hadoop.hbase.regionserver.TestWideScanner | | | hadoop.hbase.procedure.TestProcedureManager | | | hadoop.hbase.filter.TestColumnPrefixFilter | | | hadoop.hbase.master.balancer.TestRegionLocationFinder | | | hadoop.hbase.regionserver.TestKeepDeletes | | | hadoop.hbase.regionserver.TestMinVersions | | | hadoop.hbase.io.encoding.TestPrefixTree | | | hadoop.hbase.regionserver.TestScanWithBloomError | | | hadoop.hbase.regionserver.TestScanner | | | hadoop.hbase.client.TestIntraRowPagination | | | hadoop.hbase.regionserver.wal.TestWALActionsListener | | | hadoop.hbase.coprocessor.TestCoprocessorConfiguration | | | hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange | | | hadoop.hbase.filter.TestMultipleColumnPrefixFilter | | | hadoop.hbase.regionserver.TestBlocksScanned | | | hadoop.hbase.filter.TestFilterFromRegionSide | | | hadoop.hbase.regionserver.TestResettingCounters | | | hadoop.hbase.regionserver.TestStoreFileRefresherChore | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12856019/HBASE-17732.master.001.patch | | JIRA Issue | HBASE-17732 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux c6b5f5318f24 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 404a288 | | Default Java | 1.8.0_121 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/5948/artifact/patchprocess/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/5948/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/5948/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/5948/testReport/ | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5948/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Add CpType template to CoprocessorEnvironment > --------------------------------------------- > > Key: HBASE-17732 > URL: https://issues.apache.org/jira/browse/HBASE-17732 > Project: HBase > Issue Type: Improvement > Reporter: Appy > Assignee: Appy > Attachments: HBASE-17732.master.001.patch > > > Adding template for coprocessor type to CoprocessorEnvironment will: > - get rid of 'instanceOf' checks we do in various coprocessor hosts > - allow us to load only relevant coprocessors in hosts (right now i think > each host loads all coprocs and it's only during execOperation that it checks > if the coproc is of correct type ie XXCoprocessorHost will load XXObserver, > YYObserver, and all others, and in will check in execOperation if coproc is > of type XXObserver and ignore the rest). > - allow sharing of a bunch functions/classes which are currently 99% > duplicate of each other. For eg. CoprocessorOperations, > CoprocessorOperationWithResult, execOperations(). -- This message was sent by Atlassian JIRA (v6.3.15#6346)