[ 
https://issues.apache.org/jira/browse/HBASE-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174612#comment-13174612
 ] 

Anoop Sam John commented on HBASE-5088:
---------------------------------------

Good catch Jieshan

SoftValueSortedMap.headMap ()  returns a new Object of SoftValueSortedMap.
This new object's internalMap is a view of the original internalMap which is 
refered by the 1st SoftValueSortedMap..  But the view always refer and operates 
on the actual TreeMap datastructure which is not Thread safe....
Now 2 threads can operate on the 2 SoftValueSortedMap objects concurrently 
which will result in concurrent operation on a single TreeMap object..
                
> A concurrency issue on SoftValueSortedMap
> -----------------------------------------
>
>                 Key: HBASE-5088
>                 URL: https://issues.apache.org/jira/browse/HBASE-5088
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.90.4, 0.94.0
>            Reporter: Jieshan Bean
>            Assignee: Jieshan Bean
>
> SoftValueSortedMap is backed by a TreeMap. All the methods in this class are 
> synchronized. If we use this method to add/delete elements, it's ok.
> But in HConnectionManager#getCachedLocation, it use heapMap to get a view 
> from SoftValueSortedMap#internalMap. Once we operate 
> on this view map(like add/delete) in other threads, a concurrency issue may 
> occur.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to