[ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926426#comment-15926426 ]
Hudson commented on HBASE-17584: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2677 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2677/]) HBASE-17584 Expose ScanMetrics with ResultScanner rather than Scan (zhangduo: rev a49bc58a5456c2974552c7b6ffab9ea39393ca78) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/RegionAsTable.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableResultScanner.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractClientScanner.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultScanner.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/metrics/ServerSideScanMetrics.java > Expose ScanMetrics with ResultScanner rather than Scan > ------------------------------------------------------ > > Key: HBASE-17584 > URL: https://issues.apache.org/jira/browse/HBASE-17584 > Project: HBase > Issue Type: Sub-task > Components: Client, mapreduce, scan > Affects Versions: 2.0.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17584.patch, HBASE-17584-v1.patch > > > I think this have been discussed many times... It is a bad practice to > directly modify the Scan object passed in when calling getScanner. The reason > that we can not use a copy is we need to use the Scan object to expose scan > metrics. So we need to find another way to expose the metrics. -- This message was sent by Atlassian JIRA (v6.3.15#6346)