[ 
https://issues.apache.org/jira/browse/HBASE-17706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928165#comment-15928165
 ] 

Hadoop QA commented on HBASE-17706:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s {color} 
| {color:red} HBASE-17706 does not apply to master. Rebase required? Wrong 
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames 
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12859108/HBASE-17706-06.patch |
| JIRA Issue | HBASE-17706 |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/6117/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> TableSkewCostFunction improperly computes max skew
> --------------------------------------------------
>
>                 Key: HBASE-17706
>                 URL: https://issues.apache.org/jira/browse/HBASE-17706
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer
>    Affects Versions: 1.2.0
>         Environment: CentOS Derivative with a derivative of the 3.18.43 
> kernel. HBase on CDH5.9.0 with some patches. HDFS CDH 5.9.0 with no patches.
>            Reporter: Kahlil Oppenheimer
>            Assignee: Kahlil Oppenheimer
>            Priority: Minor
>              Labels: patch
>         Attachments: HBASE-17706-01.patch, HBASE-17706-02.patch, 
> HBASE-17706-03.patch, HBASE-17706-04.patch, HBASE-17706-05.patch, 
> HBASE-17706-06.patch, HBASE-17706.patch
>
>
> We noticed while running unit tests that the TableSkewCostFunction computed 
> cost did not change as the balancer ran and simulated moves across the 
> cluster. After investigating, we found that this happened in particular when 
> the cluster started out with at least one table very strongly skewed.
> We noticed that the TableSkewCostFunction depends on a field of the 
> BaseLoadBalancer.Cluster class called numMaxRegionsPerTable, but this field 
> is not properly maintained as regionMoves are simulated for the cluster. The 
> field only ever increases as the maximum number of regions per table 
> increases, but it does not decrease as the maximum number per table goes down.
> This patch corrects that behavior so that the field is accurately maintained, 
> and thus the TableSkewCostFunction produces a more correct value as the 
> balancer runs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to