[
https://issues.apache.org/jira/browse/HBASE-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929597#comment-15929597
]
Duo Zhang commented on HBASE-17691:
-----------------------------------
Add an onScanMetricsCreated method to RawScanResultConsumer and
ScanResultConsumer to pass the ScanMetrics instance to user.
And I haven't implemented the {{sumOfMillisSecBetweenNexts}} as the current
implementation seems uesless. It will record lastNext after calling next on
scanner, and use the current lastNext minus the previous lastNext and calculate
the sum. The final result just equals the whole time of the scan operation, and
in the old implementation we can only get ScanMetrics after we finish the scan,
so it does not make sense to keep a metric like this...
It was added far away from now so git blame can not tell anything. I guess the
metric is used to collect the time used by user for processing the returned
results? I.e, we should use timeBeforeNext to minus lastTimeAfterNext to get
the value which we want to add to the {{sumOfMillisSecBetweenNexts}}?
Any thoughts sir [~stack]? Thanks.
> Add ScanMetrics support for async scan
> --------------------------------------
>
> Key: HBASE-17691
> URL: https://issues.apache.org/jira/browse/HBASE-17691
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-17691.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
