[ https://issues.apache.org/jira/browse/HBASE-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175287#comment-13175287 ]
Shrijeet Paliwal commented on HBASE-5041: ----------------------------------------- @Stack {quote} I think patch is doing right thing. Its changing the contract for isRegionName but this is a private method and you are tightening what was a sloppy contract previous; it looks too like all instances of isRegionName can benefit from this tightening (is this your though Shrijeet?). {quote} Yes that is the idea. {quote} You might make a method that returns a String tablename for a table you know exists (else it throws the TNFE). {quote} Makes sense, will do. {quote} We are creating a new CatalogTracker instance. No one seems to be shutting it down? Is that a prob? {quote} Did not understand this one Stack. cleanupCatalogTracker called in finally will stop the CatalogTracker, no? > Major compaction on non existing table does not throw error > ------------------------------------------------------------ > > Key: HBASE-5041 > URL: https://issues.apache.org/jira/browse/HBASE-5041 > Project: HBase > Issue Type: Bug > Components: regionserver, shell > Affects Versions: 0.90.3 > Reporter: Shrijeet Paliwal > Assignee: Shrijeet Paliwal > Fix For: 0.92.0, 0.94.0, 0.90.6 > > Attachments: 0001-HBASE-5041-Throw-error-if-table-does-not-exist.patch > > > Following will not complain even if fubar does not exist > {code} > echo "major_compact 'fubar'" | $HBASE_HOME/bin/hbase shell > {code} > The downside for this defect is that major compaction may be skipped due to > a typo by Ops. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira