[ 
https://issues.apache.org/jira/browse/HBASE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948054#comment-15948054
 ] 

Enis Soztutar commented on HBASE-17771:
---------------------------------------

Unfortunately, there is a bug introduced in {{Row::CheckRow}} causing the 
get-test to fail. You are casting the size of the row to an {{int16_t}}, 
causing the integer overload when row.size is greater than 
{{std::numeric_limits<int16_t>::max()}}. Anyway, good that we have the get-test 
which caught it. 
{code}
void CheckRow(const std::string &row) {
    const int16_t kMaxRowLength = std::numeric_limits<int16_t>::max();
    int64_t row_length = row.size();
{code}
I've fixed the code and will push this to the branch. 

> [C++] Classes required for implementation of BatchCallerBuilder
> ---------------------------------------------------------------
>
>                 Key: HBASE-17771
>                 URL: https://issues.apache.org/jira/browse/HBASE-17771
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>             Fix For: HBASE-14850
>
>         Attachments: HBASE-17771.HBASE-14850.v1.patch, 
> HBASE-17771.HBASE-14850.v2.patch, HBASE-17771.HBASE-14850.v3.patch, 
> HBASE-17771.HBASE-14850.v4.patch, HBASE-17771.HBASE-14850.v5.patch, 
> HBASE-17771.HBASE-14850.v6.patch
>
>
> Separating depedencies of BatchCallerBuilder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to