[ 
https://issues.apache.org/jira/browse/HBASE-17890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965963#comment-15965963
 ] 

Anoop Sam John commented on HBASE-17890:
----------------------------------------

So here the test code explicitly calls the unsafe path or non unsafe path. (Non 
public methods)..  We should fix this?  The test code wanted to make sure that 
both the paths are executed from UTs.  Now we have a way to turn off Unsafe 
avail.  May be , like u did for some other tests, we will have test here which 
uses the public method path alone but have a way to execute tests with Unsafe 
toggle?
As such this patch I felt difficult to read and understand.

> FuzzyRow tests fail if unaligned support is false
> -------------------------------------------------
>
>                 Key: HBASE-17890
>                 URL: https://issues.apache.org/jira/browse/HBASE-17890
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 2.0.0, 1.2.5
>            Reporter: Jerry He
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0, 1.4.0, 1.1.10, 1.2.6, 1.3.2
>
>         Attachments: HBASE-17890.v0.branch-1.patch, HBASE-17890.v0.patch
>
>
> When unaligned support is false, FuzzyRow tests fail:
> {noformat}
> Failed tests:
>   TestFuzzyRowAndColumnRangeFilter.Test:134->runTest:157->runScanner:186 
> expected:<10> but was:<0>
>   TestFuzzyRowFilter.testSatisfiesForward:81 expected:<YES> but was:<NO_NEXT>
>   TestFuzzyRowFilter.testSatisfiesReverse:121 expected:<YES> but 
> was:<NEXT_EXISTS>
>   TestFuzzyRowFilterEndToEnd.testEndToEnd:247->runTest1:278->runScanner:343 
> expected:<6250> but was:<0>
>   TestFuzzyRowFilterEndToEnd.testFilterList:385->runTest:417->runScanner:445 
> expected:<5> but was:<0>
>   TestFuzzyRowFilterEndToEnd.testHBASE14782:204 expected:<6> but was:<0>
> {noformat}
> This can be reproduced in the case described in HBASE-17869. Or on a platform 
> really without unaligned support.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to