[
https://issues.apache.org/jira/browse/HBASE-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175883#comment-13175883
]
Phabricator commented on HBASE-5010:
------------------------------------
lhofhansl has commented on the revision "[jira] [HBASE-5010] Filter HFiles
based on TTL".
Looks pretty good. See minor comments inline.
minVersions handling looks correct to me.
I think we should call out somewhere that this optimization cannot be used
with MIN_VERSIONS enabled, along with some guess for the typical performance
penalty.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java:737 As said
in my 0.90 review, this is better package private with the test class in the
same package.
src/main/java/org/apache/hadoop/hbase/regionserver/ExplicitColumnTracker.java:74
Javadoc for oldestUnexpiredTS is missing.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java:134
Javadoc for oldestUnexpiredTS
REVISION DETAIL
https://reviews.facebook.net/D1017
> Filter HFiles based on TTL
> --------------------------
>
> Key: HBASE-5010
> URL: https://issues.apache.org/jira/browse/HBASE-5010
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D1017.1.patch, D909.1.patch, D909.2.patch
>
>
> In ScanWildcardColumnTracker we have
> {code:java}
>
> this.oldestStamp = EnvironmentEdgeManager.currentTimeMillis() - ttl;
> ...
> private boolean isExpired(long timestamp) {
> return timestamp < oldestStamp;
> }
> {code}
> but this time range filtering does not participate in HFile selection. In one
> real case this caused next() calls to time out because all KVs in a table got
> expired, but next() had to iterate over the whole table to find that out. We
> should be able to filter out those HFiles right away. I think a reasonable
> approach is to add a "default timerange filter" to every scan for a CF with a
> finite TTL and utilize existing filtering in
> StoreFile.Reader.passesTimerangeFilter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
