[ https://issues.apache.org/jira/browse/HBASE-17890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977990#comment-15977990 ]
Chia-Ping Tsai commented on HBASE-17890: ---------------------------------------- The principal aim of v3 patch is to unify the fixed/non-fixed(-1/0) byte in the FuzzyRowFilter. It is worthwhile to make the fix. # Avoid confusion for unit test. We don't need to pass different byte for unsafe/non-unsafe. # Avoid another bug. The scenario is that the unsafe is enabled on the client-side and is disabled on the server-side. The FuzzyRowFilter which is instantiated by client will convert fixed/non-fixed byte for unsafe, but the FuzzyRowFilter created on server-side doesn't convert it back for non-unsafe. (The server don't know which type of fixed/non-fixed client uses). > FuzzyRow tests fail if unaligned support is false > ------------------------------------------------- > > Key: HBASE-17890 > URL: https://issues.apache.org/jira/browse/HBASE-17890 > Project: HBase > Issue Type: Sub-task > Affects Versions: 2.0.0, 1.2.5 > Reporter: Jerry He > Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2 > > Attachments: HBASE-17890.v0.branch-1.patch, HBASE-17890.v0.patch, > HBASE-17890.v1.branch-1.patch, HBASE-17890.v1.patch, HBASE-17890.v2.patch, > HBASE-17890.v3.patch, HBASE-17890.v3.patch, HBASE-17890.v3.patch, > HBASE-17890.v3.patch, HBASE-17890.v3.patch > > > When unaligned support is false, FuzzyRow tests fail: > {noformat} > Failed tests: > TestFuzzyRowAndColumnRangeFilter.Test:134->runTest:157->runScanner:186 > expected:<10> but was:<0> > TestFuzzyRowFilter.testSatisfiesForward:81 expected:<YES> but was:<NO_NEXT> > TestFuzzyRowFilter.testSatisfiesReverse:121 expected:<YES> but > was:<NEXT_EXISTS> > TestFuzzyRowFilterEndToEnd.testEndToEnd:247->runTest1:278->runScanner:343 > expected:<6250> but was:<0> > TestFuzzyRowFilterEndToEnd.testFilterList:385->runTest:417->runScanner:445 > expected:<5> but was:<0> > TestFuzzyRowFilterEndToEnd.testHBASE14782:204 expected:<6> but was:<0> > {noformat} > This can be reproduced in the case described in HBASE-17869. Or on a platform > really without unaligned support. -- This message was sent by Atlassian JIRA (v6.3.15#6346)