[ 
https://issues.apache.org/jira/browse/HBASE-17436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981394#comment-15981394
 ] 

Ted Yu commented on HBASE-17436:
--------------------------------

The change in AssignmentManager.java is white space only - can be dropped.

Add class javadoc and annotation for MetricsRegionStates

bq. +  String METRICS_DESCRIPTION = "Metrics about HBase regions.";

Add "states" to the description.

@InterfaceAudience.Private should be added to MetricsRegionStatesSourceImpl
{code}
+    if (regionStates.containsKey(encodedName)) 
regionStates.remove(encodedName);
{code}
Why is the call to containsKey() needed ?


> Add facility to provide more information for Other Regions seen on Master UI
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-17436
>                 URL: https://issues.apache.org/jira/browse/HBASE-17436
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Janos Gub
>              Labels: ui
>         Attachments: HBASE-17436.patch, initial.patch
>
>
> [~rpednekar] and I were looking at a case where the count displayed under 
> Other Regions was high (~1200).
> Since the table page just maintains a count instead of List of region names, 
> it is very difficult for user to determine which regions belong to this 
> category.
> We should provide facility to provide more details for this category (LOG, 
> JMX, etc).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to