[ https://issues.apache.org/jira/browse/HBASE-17957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982537#comment-15982537 ]
Ted Yu commented on HBASE-17957: -------------------------------- lgtm, pending QA. > Custom metrics of replicate endpoints don't prepend "source." to global > metrics > -------------------------------------------------------------------------------- > > Key: HBASE-17957 > URL: https://issues.apache.org/jira/browse/HBASE-17957 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 2.0.0, 1.4.0, 0.98.22 > Reporter: Shinya Yoshida > Priority: Minor > Attachments: HBASE-17957.master.001.patch > > > Custom metrics for custom replication endpoints is introduced by > [HBASE-16448]. > The name of local custom metrics follows the "source.id.metricsName" format, > but the name of global custom metrics doesn't follow the "source.metricsName" > format. > Ex: > {code} > // default metrics > "source.2.shippedOps" : 1234, // peer local > "source.shippedOps" : 12345, // global > // custom metrics > "source.1.failed.start" : 1, // peer local > "failed.start" : 1, // global > {code} > When we consider that default metrics do so, it should be > "source.metricsName" like: > {code} > "source.1.failed.start" : 1, > "source.failed.start" : 1, > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)