[ https://issues.apache.org/jira/browse/HBASE-17975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989008#comment-15989008 ]
Josh Elser commented on HBASE-17975: ------------------------------------ +1 on QA Looks like we should also do a check for other references of these methods (shaded and not-shaded ProtobufUtil variants) to proactively catch this same bug? > TokenUtil.obtainToken squashes remote exceptions > ------------------------------------------------ > > Key: HBASE-17975 > URL: https://issues.apache.org/jira/browse/HBASE-17975 > Project: HBase > Issue Type: Bug > Components: mapreduce, security > Affects Versions: 2.0.0 > Reporter: Sean Busbey > Assignee: Sean Busbey > Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-17975.0.patch > > > In the changes to protobuf handling in HBASE-15638, our TokenUtil class went > from handling remote exception via a method that would throw IOException to > one that simply returned it. In doing so, we ended up ignoring the results. > This causes the obtainToken method to start returning null where it would > have previously thrown an IOException. It also causes obtainTokenForJob to > still fail with an IOException, but instead of being the underlying remote > problem now it's a generic "I didn't get a user token for some reason." > found via testing Pig with errors. > {code} > Caused by: java.io.IOException: No token returned for user > testu...@example.com > at > org.apache.hadoop.hbase.security.token.TokenUtil.obtainTokenForJob(TokenUtil.java:175) > at > org.apache.pig.backend.hadoop.hbase.HBaseStorage.addHBaseDelegationToken(HBaseStorage.java:887) > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)