[
https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-3274:
-------------------------------
Attachment: HBASE-3274.D1053.1.patch
QwertyManiac requested code review of "HBASE-3274 [jira] Replace all config
properties references in code with string constants".
Reviewers: JIRA
Fixes for source packages avro to io.
See HBASE-2721 for details. We have fixed the default values in HBASE-3272
but we should also follow Hadoop to remove all hardcoded strings that refer to
configuration properties and move them to HConstants.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1053
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HConstants.java
src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
src/main/java/org/apache/hadoop/hbase/client/HTable.java
src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2199/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Replace all config properties references in code with string constants
> ----------------------------------------------------------------------
>
> Key: HBASE-3274
> URL: https://issues.apache.org/jira/browse/HBASE-3274
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars George
> Assignee: Harsh J
> Priority: Trivial
> Attachments: HBASE-3274.D1053.1.patch
>
> Original Estimate: 168h
> Time Spent: 2h
> Remaining Estimate: 166h
>
> See HBASE-2721 for details. We have fixed the default values in HBASE-3272
> but we should also follow Hadoop to remove all hardcoded strings that refer
> to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
