[
https://issues.apache.org/jira/browse/HBASE-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991340#comment-15991340
]
Sean Busbey commented on HBASE-15199:
-------------------------------------
General approach looks good.
{quote}
./bin/hbase:313:14: error: Double quote array expansions to avoid re-splitting
elements. [SC2068]
./bin/hbase:314:19: warning: Quote the rhs of == in [[ ]] to prevent glob
matching. [SC2053]
./bin/hbase:321:29: warning: Brace expansions and globs are literal in
assignments. Quote it or use an array. [SC2125]
{quote}
Could you correct these shellcheck errors please?
{code}
+ # add JRUBY_PACKAGED_WITH_HBASE to CLASSPATH when jruby is needed
+ JRUBY_PACKAGED_WITH_HBASE=$HBASE_HOME/lib/ruby/*
{code}
Shouldn't this be just the jruby jar, rather than e.g. also the ruby sources.
> Move jruby jar so only on hbase-shell module classpath; currently globally
> available
> ------------------------------------------------------------------------------------
>
> Key: HBASE-15199
> URL: https://issues.apache.org/jira/browse/HBASE-15199
> Project: HBase
> Issue Type: Task
> Components: dependencies, jruby, shell
> Reporter: stack
> Assignee: Xiang Li
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: 15199.txt, HBASE-15199.master.001.patch,
> HBASE-15199.master.002.patch
>
>
> A suggestion that came up out of internal issue (filed by Mr Jan Van Besien)
> was to move the scope of the jruby include down so it is only a dependency
> for the hbase-shell. jruby jar brings in a bunch of dependencies (joda time
> for example) which can clash with the includes of others. Our Sean suggests
> that could be good to shut down exploit possibilities if jruby was not
> globally available. Only downside I can think is that it may no longer be
> available to our bin/*rb scripts if we move the jar but perhaps these can be
> changed so they can find the ruby jar in new location.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
