[
https://issues.apache.org/jira/browse/HBASE-17887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004352#comment-16004352
]
Chia-Ping Tsai commented on HBASE-17887:
----------------------------------------
v5 for branch-1 --
{code}
- scanners = selectScannersFrom(store.getScanners(flushedStoreFiles,
cacheBlocks, get, usePread,
+ List<KeyValueScanner> allScanners = new
ArrayList<>(flushedStoreFiles.size() + memStoreScannersAfterFlush.size());
+ allScanners.addAll(store.getScanners(flushedStoreFiles, cacheBlocks,
get, usePread,
isCompaction, matcher, scan.getStartRow(), scan.getStopRow(),
this.readPt, true));
{code}
We already have the memstore scanner so it is unnecessary to require the
memstore scanner over getScanners. I will fix it in branch-1.v6 patch
> TestAcidGuarantees fails frequently
> -----------------------------------
>
> Key: HBASE-17887
> URL: https://issues.apache.org/jira/browse/HBASE-17887
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 2.0.0
> Reporter: Umesh Agashe
> Assignee: Chia-Ping Tsai
> Priority: Blocker
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.4.1
>
> Attachments: HBASE-17887.branch-1.v0.patch,
> HBASE-17887.branch-1.v1.patch, HBASE-17887.branch-1.v1.patch,
> HBASE-17887.branch-1.v2.patch, HBASE-17887.branch-1.v2.patch,
> HBASE-17887.branch-1.v3.patch, HBASE-17887.branch-1.v4.patch,
> HBASE-17887.branch-1.v4.patch, HBASE-17887.branch-1.v4.patch,
> HBASE-17887.branch-1.v5.patch, HBASE-17887.ut.patch, HBASE-17887.v0.patch,
> HBASE-17887.v1.patch, HBASE-17887.v2.patch, HBASE-17887.v3.patch
>
>
> As per the flaky tests dashboard here:
> https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html,
> It fails 30% of the time.
> While working on HBASE-17863, a few verification builds on patch failed due
> to TestAcidGuarantees didn't pass. IMHO, the changes for HBASE-17863 are
> unlikely to affect get/ put path.
> I ran the test with and without the patch several times locally and found
> that TestAcidGuarantees fails without the patch similar number of times.
> Opening blocker, considering acid guarantees are critical to HBase.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
