[
https://issues.apache.org/jira/browse/HBASE-17286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016593#comment-16016593
]
Josh Elser commented on HBASE-17286:
------------------------------------
bq. the execution id changed so our code no longer got called
While I can understand why your patch works, I don't think that's the right way
to fix this. We're relying on whatever the maintainers of the apache pom call
their execution. Instead, shouldn't we be configuring the goal of our execution
so that it is invoked regardless? The id is just some descriptive string --
it's just happenstance that we choose the same one as the parent pom (which
happens to be set up with that goal)
Something like..
{code}
<id>default</id>
+ <goals>
+ <goal>process</goal>
+ </goals>
{code}
This appears to have done the same thing you set out to do.
> LICENSE.txt in binary tarball contains only ASL text
> ----------------------------------------------------
>
> Key: HBASE-17286
> URL: https://issues.apache.org/jira/browse/HBASE-17286
> Project: HBase
> Issue Type: Bug
> Components: build, community
> Reporter: Josh Elser
> Assignee: Mike Drob
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-17286.patch
>
>
> Noticed this one today because I needed to make sure LICENSE was getting
> updated for a patch-in-progress.
> What I'm presently seeing after invoking {{mvn clean package assembly:single
> -DskipTests -Drat.skip -Prelease}} on master is that the LICENSE.txt file
> contains only the ASL text (which I know for certain it should contain BSD
> and MIT as well).
> I checked branch-1.2 which has lots of extra greatness, so it seems like
> something happened in master which broke this. Filing this now so we can try
> to bisect and figure out what happened.
> FYI, this is the one I was chatting you about [~busbey].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
