[ https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024079#comment-16024079 ]
Hudson commented on HBASE-18060: -------------------------------- FAILURE: Integrated in Jenkins build HBase-1.4 #747 (See [https://builds.apache.org/job/HBase-1.4/747/]) HBASE-18060 Backport to branch-1 HBASE-9774 HBase native metrics and (apurtell: rev a3c3f1012d0eae531c8f38ac5c7e7b81402d8a84) * (add) hbase-metrics-api/pom.xml * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java * (add) hbase-metrics/src/test/java/org/apache/hadoop/hbase/metrics/impl/TestGauge.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistryImpl.java * (edit) hbase-server/pom.xml * (edit) hbase-assembly/pom.xml * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSourceImpl.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/util/LongAdder.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java * (add) hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/metrics/impl/TestGlobalMetricRegistriesAdapter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/AgeSnapshot.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistriesLoader.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorMetrics.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/metrics/BaseSourceImpl.java * (add) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/metrics/impl/GlobalMetricRegistriesAdapter.java * (add) hbase-metrics-api/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricRegistriesLoader.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/FastLongHistogram.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Meter.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/DefaultMetricsSystemHelper.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableRangeHistogram.java * (delete) hbase-common/src/main/java/org/apache/hadoop/hbase/util/FastLongHistogram.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistryFactory.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/CounterImpl.java * (add) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/metrics/impl/HBaseMetrics2HadoopMetricsAdapter.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricSet.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionCoprocessorEnvironment.java * (add) hbase-metrics/src/test/java/org/apache/hadoop/hbase/metrics/impl/TestCounterImpl.java * (add) hbase-metrics-api/README.txt * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java * (add) hbase-metrics/pom.xml * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/package-info.java * (add) hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/ExampleRegionObserverWithMetrics.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/DropwizardMeter.java * (edit) hbase-hadoop-compat/pom.xml * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java * (add) hbase-metrics/src/test/java/org/apache/hadoop/hbase/metrics/impl/TestHistogramImpl.java * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/util/Striped64.java * (edit) hbase-hadoop2-compat/pom.xml * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * (edit) hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/metrics/BaseSource.java * (delete) hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestFastLongHistogram.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistry.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Histogram.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistryFactoryImpl.java * (add) hbase-metrics/src/main/resources/META-INF/services/org.apache.hadoop.hbase.metrics.MetricRegistries * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionServerCoprocessorEnvironment.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/WALCoprocessorEnvironment.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistryInfo.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/TimerImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java * (add) hbase-metrics/src/test/java/org/apache/hadoop/hbase/metrics/impl/TestMetricRegistryImpl.java * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MetricsCoprocessor.java * (add) hbase-examples/src/main/java/org/apache/hadoop/hbase/coprocessor/example/ExampleMasterObserverWithMetrics.java * (edit) hbase-resource-bundle/src/main/resources/supplemental-models.xml * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterCoprocessorEnvironment.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Gauge.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Timer.java * (add) hbase-metrics/src/test/java/org/apache/hadoop/hbase/metrics/impl/TestRefCountingMap.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Counter.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Metric.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/Snapshot.java * (add) hbase-metrics/src/test/java/org/apache/hadoop/hbase/metrics/impl/TestTimerImpl.java * (add) hbase-metrics/README.txt * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/MetricRegistries.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java * (add) hbase-metrics/src/test/java/org/apache/hadoop/hbase/metrics/impl/TestDropwizardMeter.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/package-info.java * (edit) pom.xml * (add) hbase-metrics/src/test/java/org/apache/hadoop/hbase/metrics/impl/TestFastLongHistogram.java * (add) hbase-metrics-api/src/main/java/org/apache/hadoop/hbase/metrics/PackageMarker.java * (add) hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/RefCountingMap.java > Backport to branch-1 HBASE-9774 HBase native metrics and metric collection > for coprocessors > ------------------------------------------------------------------------------------------- > > Key: HBASE-18060 > URL: https://issues.apache.org/jira/browse/HBASE-18060 > Project: HBase > Issue Type: New Feature > Reporter: Vincent Poon > Assignee: Vincent Poon > Fix For: 1.4.0 > > Attachments: HBASE-18060.branch-1.3.v1.patch, > HBASE-18060.branch-1.3.v2.patch, HBASE-18060.branch-1.3.v3.patch, > HBASE-18060.branch-1.3.v4.patch, HBASE-18060.branch-1.3.v5.patch, > HBASE-18060.branch-1.v1.patch, HBASE-18060.branch-1.v2.patch, > HBASE-18060.branch-1.v3.patch, HBASE-18060.branch-1.v4.patch, > HBASE-18060.branch-1.v5.patch, HBASE-18060.branch-1.v6.patch > > > I'd like to explore backporting HBASE-9774 to branch-1, as the ability for > coprocessors to report custom metrics through HBase is useful for us, and if > we have coprocessors use the native API, a re-write won't be necessary after > an upgrade to 2.0. > The main issues I see so far are: > - the usage of Java 8 language features. Seems we can work around this as > most of it is syntactic sugar. Will need to find a backport for LongAdder > - dropwizard 3.1.2 in Master. branch-1 is still on yammer metrics 2.2. Not > sure if these can coexist just for this feature -- This message was sent by Atlassian JIRA (v6.3.15#6346)