[ https://issues.apache.org/jira/browse/HBASE-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178198#comment-13178198 ]
Hadoop QA commented on HBASE-5114: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12509014/5114.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -151 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 77 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRolling org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/646//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/646//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/646//console This message is automatically generated. > TestMetaReaderEditor can timeout during test execution > ------------------------------------------------------ > > Key: HBASE-5114 > URL: https://issues.apache.org/jira/browse/HBASE-5114 > Project: HBase > Issue Type: Bug > Components: test > Affects Versions: 0.94.0 > Reporter: nkeywal > Assignee: nkeywal > Attachments: 5114.patch > > > Likely because it belongs to the too long list of flaky tests. A test should > not fail randomly. Here is the list, from 2974 to 2598, with a timeouted > TestMetaReaderEditor > https://builds.apache.org/job/HBase-TRUNK/2597/testReport/org.apache.hadoop.hbase.catalog/ > https://builds.apache.org/job/HBase-TRUNK/2588/testReport/org.apache.hadoop.hbase.catalog/ > https://builds.apache.org/job/HBase-TRUNK/2585/testReport/org.apache.hadoop.hbase.catalog/ > https://builds.apache.org/job/HBase-TRUNK/2584/testReport/org.apache.hadoop.hbase.catalog/ > https://builds.apache.org/job/HBase-TRUNK/2582/testReport/org.apache.hadoop.hbase.catalog/ > https://builds.apache.org/job/HBase-TRUNK/2577/testReport/org.apache.hadoop.hbase.catalog/ > https://builds.apache.org/job/HBase-TRUNK/2574/testReport/org.apache.hadoop.hbase.catalog/ > It happens on hadoop-qa as well: > https://builds.apache.org/job/PreCommit-HBASE-Build/640/testReport/org.apache.hadoop.hbase.catalog/ > https://builds.apache.org/job/PreCommit-HBASE-Build/638/testReport/org.apache.hadoop.hbase.catalog/ > https://builds.apache.org/job/PreCommit-HBASE-Build/630/testReport/org.apache.hadoop.hbase.catalog/ > https://builds.apache.org/job/PreCommit-HBASE-Build/622/testReport/org.apache.hadoop.hbase.catalog/ > Looking at the source code, main issues are: > - in testRetrying, some threads are started, but will not be stopped if an > assertion fails. As a consequence, the process will not stop > - still in testRetrying, it's not possible to use @Test(timeout=180000), > because if this timeout is reached, the thread won't be stopped. > This does not explain why the test fails sometimes, but explain why we have a > timeout instead of a clean failure. > I also fixed some stuff that seems unrelated, and I cannot reproduce the > error anymore locally after 10 tries. So I will try the patch on hadoop-qa. > The patch includes as well the removal of TestAdmin#testHundredsOfTable > because this test takes 2 minutes to execute; but proves nothing on success > as there is no check on ressources used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira